Skip to content

feat: merge next branch into main#70

Merged
cjquines merged 2 commits into
mainfrom
next
Jul 9, 2025
Merged

feat: merge next branch into main#70
cjquines merged 2 commits into
mainfrom
next

Conversation

@cjquines
Copy link
Copy Markdown
Contributor

@cjquines cjquines commented Jul 9, 2025

merges build-sdk-action into main, with some changes

changes compared to build-sdk-action:

  • versioning starts from 1.0.0, so the first release will be 1.0.0
  • the versioning policy is different
  • examples are against v1 (which does not exist yet, but will after release please runs and we do the release motions)
    • the actual release flow has been tested on build-sdk-action
  • references to the action name have been changed to upload-openapi-spec-action
  • the main action has been moved to /build

for compatibility, note that:

  • the main action.yml is essentially unchanged
  • the main .gitlab-ci.yml is essentially unchanged
  • the src/index.ts, which is used to build dist/index.js, is unchanged. the actual dist file is different because the way we build it is different (using esbuild instead of ncc)

@cjquines cjquines changed the base branch from main to cj/prepare-merge July 9, 2025 17:51
@cjquines cjquines force-pushed the next branch 2 times, most recently from 08a8125 to 9f07f88 Compare July 9, 2025 18:15
Base automatically changed from cj/prepare-merge to main July 9, 2025 18:22
@cjquines cjquines marked this pull request as ready for review July 9, 2025 18:30
Copy link
Copy Markdown
Member

@meorphis meorphis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skimmed and LGTM. a little weird to have a top-level action.yml as well as build/action.yml but it's probably the best call for backwards compatibility

@cjquines cjquines merged commit 15b8b59 into main Jul 9, 2025
2 checks passed
@cjquines cjquines deleted the next branch July 9, 2025 21:01
etkramer pushed a commit that referenced this pull request Dec 3, 2025
* feat: add preview actions

* docs: rewrite versioning policy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants